-
Notifications
You must be signed in to change notification settings - Fork 39
Add IPv4 address usage and quota metrics per subnet #192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add vpc_ipv4addressespersubnet_quota metric (CIDR-based capacity) - Add vpc_ipv4addressespersubnet_usage metric (currently used IPs)
d253f4c to
438ffbb
Compare
|
/ok-to-test |
1 similar comment
|
/ok-to-test |
hemslo
reviewed
Oct 9, 2025
rporres
reviewed
Oct 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx a lot for your contribution. Two minor comments.
To avoid confusion with actual AWS Service Quotas, as the capacity here is determined by the subnets CIDR.
|
Thanks for the reviews! |
|
/ok-to-test |
rporres
approved these changes
Oct 9, 2025
hemslo
approved these changes
Oct 10, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to monitor ipv4 address usage of subnets
Adds
Note that the "quota" metric is not an aws quota, but the capacity of the subnet as defined by the assigned CIDR.
We could possibly use '_capacity' instead of '_quota' but this way it is in line with the rest of the metrics and should be semantically "correct".
https://issues.redhat.com/browse/SREP-114